OCPBUGS-61088: revert PR #2738, enhance test for config_test.go and let CVO manage CMO networkpolicies #2740
Conversation
…monitorin…" This reverts commit df94b18.
…tpol at the end for CMO
|
/retitle OCPBUGS-61088: revert PR #2738, enhance test for config_test.go and deploy the denyNetpol at the end for CM |
openshift-ci
bot
changed the title
openshift-ci-robot
added
jira/valid-reference
|
@juzhao: This pull request references Jira Issue OCPBUGS-61088, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@openshift-ci-robot: GitHub didn't allow me to request PR reviews from the following users: juzhao. Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/retest-required |
|
/payload 4.21 ci blocking |
|
@juzhao: trigger 5 job(s) of type blocking for the ci release of OCP 4.21
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/da78fdd0-be32-11f0-85e8-21ed1844d3c0-0 trigger 13 job(s) of type blocking for the nightly release of OCP 4.21
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/da78fdd0-be32-11f0-85e8-21ed1844d3c0-1 |
|
/retest-required |
juzhao
changed the title
|
/test e2e-aws-ovn-techpreview |
|
/payload 4.21 ci blocking |
|
@juzhao: trigger 5 job(s) of type blocking for the ci release of OCP 4.21
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/aa093d90-bf95-11f0-96c5-34b15ddbb7e8-0 |
|
/payload 4.21 ci blocking |
|
@juzhao: trigger 5 job(s) of type blocking for the ci release of OCP 4.21
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/d9d0e6c0-bfce-11f0-95c3-cd880f2da26a-0 |
|
/payload-aggregate periodic-ci-openshift-release-master-ci-4.21-upgrade-from-stable-4.20-e2e-aws-ovn-upgrade 10 |
|
@juzhao: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/c71aec10-c037-11f0-9f7e-42e20bf35f9d-0 |
|
/payload-aggregate periodic-ci-openshift-release-master-ci-4.21-upgrade-from-stable-4.20-e2e-azure-ovn-upgrade 10 |
|
@juzhao: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/4c4c15d0-c065-11f0-9b2c-9da27073789c-0 |
|
run |
|
I agree that the previous upgrade issues are no longer present and the test failures we see do not appear to be related. |
|
/verified by @juzhao |
openshift-ci-robot
added
the
verified
|
@juzhao: This PR has been marked as verified by In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@neisw: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/49da2620-c952-11f0-860a-5a522e335451-0 |
|
Thanks @juzhao I didn't see anything in the jobs your ran or the ones I retested. I think you are ok to unhold. |
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
openshift-ci-robot
added
the
verified
|
@juzhao: This PR has been marked as verified by In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
thanks, will do in the follow up PR |
openshift-ci-robot
removed
the
verified
…her files based on comment
|
the change is due to openshift/library-go bump, PR: #2751 |
|
/verified by @juzhao |
openshift-ci-robot
added
the
verified
|
@juzhao: This PR has been marked as verified by In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/payload 4.21 ci blocking |
|
@juzhao: trigger 5 job(s) of type blocking for the ci release of OCP 4.21
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/82c68d00-c9d6-11f0-899f-cc6791df983d-0 |
|
@machine424 please review again, the change is due to the api change, also fixed PR according to your comments, see: #2740 (comment) |
|
/payload 4.21 nightly blocking |
|
@juzhao: trigger 13 job(s) of type blocking for the nightly release of OCP 4.21
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/dae03470-ca01-11f0-98a2-200e18189a59-0 |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: juzhao, machine424 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest-required |
|
@juzhao: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
@juzhao: Jira Issue Verification Checks: Jira Issue OCPBUGS-61088 Jira Issue OCPBUGS-61088 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
4 participants
revert PR: #2738 which reverted PR #2656
and added 2 enhancements: